Avtansh88 commented on PR #5666:
URL: https://github.com/apache/fineract/pull/5666#issuecomment-4229842913
Hi @adamsaghy,
I have fixed the Checkstyle violations and the build is now passing locally.
Key Implementation Details:
Utility Class Pattern: To resolve the HideUtilityClassConstructor violation,
I have made the constructors of UserHelper and RolesHelper private.
Defensive Coding: Inside these private constructors, I’ve added throw new
UnsupportedOperationException("This is a utility class and cannot be
instantiated") to strictly prevent any runtime instantiation.
Refactored Callers: I've updated MakercheckerTest and other integration
tests to use static method calls (e.g., UserHelper.createUser(...)) to align
with this modernization.
Verification: Verified locally with ./gradlew
:integration-tests:checkstyleTest and compileTestJava. Both are now showing
Successful Build.
Ready for your review..
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
