oleksii-novikov-onix commented on code in PR #5767:
URL: https://github.com/apache/fineract/pull/5767#discussion_r3079513646
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/domain/WorkingCapitalLoanPeriodFrequencyType.java:
##########
@@ -32,8 +32,9 @@
public enum WorkingCapitalLoanPeriodFrequencyType implements
ApiFacingEnum<WorkingCapitalLoanPeriodFrequencyType> {
DAYS(1, "DAYS", "Days"), //
- MONTHS(2, "MONTHS", "Months"), //
- YEARS(3, "YEARS", "Years") //
+ WEEKS(2, "WEEKS", "Weeks"), //
Review Comment:
The value reordering is safe, the enum is persisted as EnumType.STRING, and
the numeric value field is not used anywhere in the codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
