alberto-art3ch commented on code in PR #5740:
URL: https://github.com/apache/fineract/pull/5740#discussion_r3102338723
##########
fineract-core/src/main/java/org/apache/fineract/infrastructure/core/data/ApiGlobalErrorResponse.java:
##########
@@ -152,10 +152,11 @@ public static ApiGlobalErrorResponse notImplemented(final
String globalisationMe
public static ApiGlobalErrorResponse dataIntegrityError(final String
globalisationMessageCode, final String defaultUserMessage,
final String parameterName, final Object...
defaultUserMessageArgs) {
final List<ApiParameterError> errors = new ArrayList<>();
- errors.add(ApiParameterError.parameterError(globalisationMessageCode,
defaultUserMessage, parameterName, defaultUserMessageArgs));
+ final String developerMessage = "The request caused a data integrity
issue to be fired by the database.";
Review Comment:
It was requested for testing, and in my opinion the `developerMessage` and
`defaultUserMessage` were the same. I think is more useful to have this
different. Usually in those Data Integrity error we had the database error,
like constraint failure or duplicate data, etc
In the past the `developerMessage` in root was different to the
`error.developerMessage` value
<img width="1462" height="987" alt="Screenshot 2026-04-16 at 5 34 43 PM"
src="https://github.com/user-attachments/assets/2d61cd60-ebe9-465f-af6b-68e3ec727f78";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
