alberto-art3ch commented on code in PR #5775:
URL: https://github.com/apache/fineract/pull/5775#discussion_r3111605748
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/workingcapitalloan/WorkingCapitalLoanApplicationTestBuilder.java:
##########
@@ -209,12 +209,8 @@ public String buildModifyJson() {
if (delinquencyBucketId != null) {
json.addProperty("delinquencyBucketId", delinquencyBucketId);
}
- if (delinquencyGraceDays != null) {
- json.addProperty("delinquencyGraceDays", delinquencyGraceDays);
- }
- if (delinquencyStartType != null) {
- json.addProperty("delinquencyStartType", delinquencyStartType);
- }
+ json.addProperty("delinquencyGraceDays", delinquencyGraceDays);
Review Comment:
There are cases where we need to override a X value added previously and
then later we don't want to have, so we must to send a null value. In the tests
with this conditional we are not able to send null value, so we can not
override values.
And the short answer is, Yes we are evaluating the null values, If the null
value exists so we can take the value from the WC Product. Please see the above
WC Loan assembler that validates this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
