adamsaghy commented on PR #5785: URL: https://github.com/apache/fineract/pull/5785#issuecomment-4303225521
> Hi @adamsaghy, > > I attempted to review the ticket at https://issues.apache.org/jira/browse/FINERACT-2455 , but I couldn’t find any clearly documented use case or requirements associated with it. I also noticed that several PRs have already been merged under this ticket. > > My main concern is that most of the documentation appears to reside within the codebase (e.g., adoc files), rather than being captured in the ticket or on the dev mailing list. Could you please confirm if there are additional discussions or references that should be reviewed? > > Since you are leading this feature, it would be very helpful if the implementation scope and requirements were clearly outlined in the ticket to ensure better visibility and alignment for contributors. It would also greatly assist newcomers when reviewing the code and trying to understand or ask questions about the intended use cases. > > Thanks. Hi @Aman-Mittal You are right, we should have some documentation under the Apache Fineract Jira tickets as well. Let me review the umbrella ticket and add the missing informations. In the meantime, the `fineract-doc` and the PR implementation reflects the behaviour (in this case, there is no difference it behaviour, just a different loan product) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
