bharathcgowda commented on PR #5780: URL: https://github.com/apache/fineract/pull/5780#issuecomment-4341608507
> > > > > @alberto-art3ch It seems GA check is giving error prone issue on fineract-tax:compileTestJava can you please check. > > > > > While i tried to look at the ticket. Can you confirm me the tax bifurcation logic. Asking based on usecase perspective while on ticket i tried to cross-check I cannot seem to understand how tax logic should be calculated not much relevant data i can find. > > > > > > > > > > > > > @alberto-art3ch It seems GA check is giving error prone issue on fineract-tax:compileTestJava can you please check. > > > > > While i tried to look at the ticket. Can you confirm me the tax bifurcation logic. Asking based on usecase perspective while on ticket i tried to cross-check I cannot seem to understand how tax logic should be calculated not much relevant data i can find. > > > > > > > > > > > > I've reviewed the compilation issue in the fineract-tax Test part and solved. Thanks. > > > > About the bifurcation logic about the Taxes in the Loan Charges is: If you have a Loan Charge with 100.00 as amount and you have a Tax of 15% in this case, the client pays the same 100.00 but internally (in the accounting) you will have three Journal Entries: > > > > GL ACCOUNT > > > > DEBIT > > > > CREDIT > > > > Fees Receivables > > > > 100.00 > > > > Income For Fees > > > > 85.00 > > > > Tax Liability > > > > 15.00 > > > > The Tax liability account is taken from Tax Component definition, and obviously it is linked to the Charge using the Tax Group > > > > We are trying to follow a similar approach that we have in the Savings, so we are creating entities to have the detail about which Taxes (if apply) are being paying on the repayment transactions > > > > Please let me know any comment or doubt > > > > > > > > > Yes, can you tell me is there any way user can check how much tax he has paid till now. It will be better for compliance. While I also want to make sure that tax bifurcation is also documented on ticket too. > > > > > > To start, in the Loan Charge entity there is a new field that will store the Tax Amount (sum of all the different Taxes applied) of this Loan Charge. > > Plus there is a new entity named LoanChargeTaxDetails that stores (in detail) the relation between Loan Charge and Tax Component and the amount of this. > > In resume the data is already there, one way to know (as other ones) is with a report, or maybe we can extend the Loan Charge api details to have that data > > Need to ask Bharat and other PMC member for this. Thanks for explaining. > > I just want to make sure these things are documented properly. @Aman-Mittal Appreciate all your questions and the detailed code review. The functionality explained by @alberto-art3ch looks correct for the inclusive tax configuration. I also believe we can further enhance the tax bifurcation space over time, and those improvements can be handled through separate stories instead of being part of this ticket. @alberto-art3ch , as mentioned by @adamsaghy , could you please document the current behavior in the fineract-doc module under FINERACT-1289? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
