San-43 commented on code in PR #5816:
URL: https://github.com/apache/fineract/pull/5816#discussion_r3162362361
##########
fineract-provider/src/main/java/org/apache/fineract/accounting/journalentry/service/AccrualBasedAccountingProcessorForLoan.java:
##########
@@ -104,6 +104,11 @@ else if ((transactionType.isWriteOff() ||
transactionType.isWaiveInterest() || t
createJournalEntriesForWriteOffs(loanDTO, loanTransactionDTO,
office);
}
+ // Handle Transfers
+ else if (transactionType.isInitiateTransfer() ||
transactionType.isApproveTransfer() || transactionType.isWithdrawTransfer()) {
+ createJournalEntriesForTransfers(loanDTO, loanTransactionDTO,
office);
Review Comment:
Yes. In the loan transfer flow, transfer cancellation is represented by
`WITHDRAW_TRANSFER`.
For transfer withdrawal/cancellation, the expected accounting direction is
the same debit/credit direction as transfer approval: DR Loan Portfolio and CR
Transfers in suspense. The office is not hardcoded as Office B; it comes from
the transfer transaction office.
So for a cancelled transfer, the withdrawal transaction is posted under
Office A, and the journal entry becomes:
- DR Loan Portfolio (Office A)
- CR Transfers in suspense (Office A)
The last image in the PR description shows the `Transfer withdraw` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
