budaidev commented on code in PR #5822:
URL: https://github.com/apache/fineract/pull/5822#discussion_r3188642204
##########
fineract-e2e-tests-core/src/test/java/org/apache/fineract/test/data/RepaymentStartDateType.java:
##########
@@ -16,23 +16,21 @@
* specific language governing permissions and limitations
* under the License.
*/
-package org.apache.fineract.integrationtests.client.feign.helpers;
+package org.apache.fineract.test.data;
-import static org.apache.fineract.client.feign.util.FeignCalls.ok;
+import lombok.Getter;
-import java.util.List;
-import org.apache.fineract.client.feign.FineractFeignClient;
-import org.apache.fineract.client.models.GetSearchResponse;
+@Getter
+public enum RepaymentStartDateType {
-public class FeignSearchHelper {
+ DINVALID(0), //
Review Comment:
is this values is on purpose? Shouldn't it INVALID?
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -431,6 +432,9 @@ public class Loan extends
AbstractAuditableWithUTCDateTimeCustom<Long> {
@Column(name = "allow_full_term_for_tranche", nullable = false)
private boolean allowFullTermForTranche = false;
+ @Column(name = "repayment_start_date_type_enum", nullable = false)
Review Comment:
Should this be nullable or not? Liquibase allows it, the entity doesn't.
` <constraints nullable="true"/>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
