Aman-Mittal commented on code in PR #5828:
URL: https://github.com/apache/fineract/pull/5828#discussion_r3201267727
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/domain/Loan.java:
##########
@@ -79,7 +79,6 @@
import org.apache.fineract.portfolio.loanproduct.domain.LoanProduct;
import
org.apache.fineract.portfolio.loanproduct.domain.LoanProductRelatedDetail;
import
org.apache.fineract.portfolio.loanproduct.domain.LoanSupportedInterestRefundTypes;
-import org.apache.fineract.portfolio.loanproduct.domain.RepaymentStartDateType;
Review Comment:
Like to know the reasoning behind removing this column
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/loanschedule/service/LoanScheduleAssembler.java:
##########
@@ -271,7 +271,7 @@ private LoanApplicationTerms
assembleLoanApplicationTermsFrom(final JsonElement
LocalDate repaymentsStartingFromDate =
this.fromApiJsonHelper.extractLocalDateNamed("repaymentsStartingFromDate",
element);
final LocalDate submittedOnDate =
this.fromApiJsonHelper.extractLocalDateNamed("submittedOnDate", element);
- RepaymentStartDateType repaymentStartDateType =
loanProduct.getRepaymentStartDateType();
+ RepaymentStartDateType repaymentStartDateType =
loanProduct.getLoanProductRelatedDetail().getRepaymentStartDateType();
Review Comment:
I noticed that you’re migrating to LoanProductRelatedDetail instead of using
LoanProduct.
Could you clarify the difference between the two in terms of intended usage?
Based on the ticket, it seems that LoanProduct was previously the source of
truth for repaymentStartDateType, and this responsibility has now been moved to
LoanProductRelatedDetail.
From my understanding, LoanProductRelatedDetail was introduced to avoid
downstream impacts and schema changes on existing entities caused by modifying
LoanProduct. Please correct me if I’m misunderstanding the rationale.
Also, are there any tests or Fineract documentation updates implemented for
this change, or are those planned for a future update?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
