Harshdhall01 opened a new pull request, #5844:
URL: https://github.com/apache/fineract/pull/5844

   ## Description
   
   Several files in the `fineract-loan` module contained stale IDE-generated 
   comments (`// TODO Auto-generated constructor stub` and 
   `// TODO Auto-generated method stub`) that were accidentally left behind 
   when these methods were implemented.
   
   These comments serve no purpose and can mislead contributors into thinking 
   the methods are incomplete or unimplemented — when in reality they are 
   fully functional. Every other similar constructor/method in the codebase 
   does not have these noise comments.
   
   Fixed by removing 3 stale TODO comments from:
   - `LoanInstallmentCharge.java` — empty default constructor
   - `DuplicateGuarantorException.java` — constructor with super() call  
   - `LoanTransaction.java` — `isNotRefundForActiveLoan()` method
   
   I am exploring this codebase as part of my DMP 2026 application for the 
   Dynamic Pricing of Micro-loans Using Reinforcement Learning project. 
   The loan module is directly relevant as it contains the core installment 
   and transaction logic that my RL environment will model for dynamic 
   pricing decisions.
   
   ## Checklist
   - [x] Write the commit message as per our guidelines
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
— it is your responsibility to get a proposed PR to pass the build, not 
primarily the project's maintainers.
   - [ ] Create/update unit or integration tests for verifying the changes made.
   - [x] Follow our coding conventions.
   - [ ] Add required Swagger annotation and update API documentation
   - [x] This PR must not be a "code dump".


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to