vidakovic commented on code in PR #5773:
URL: https://github.com/apache/fineract/pull/5773#discussion_r3257723450
##########
fineract-investor/src/main/java/org/apache/fineract/investor/service/CancelTransactionFromExternalAssetOwnerHandler.java:
##########
@@ -18,22 +18,35 @@
*/
package org.apache.fineract.investor.service;
+import io.github.resilience4j.retry.annotation.Retry;
import lombok.RequiredArgsConstructor;
-import org.apache.fineract.commands.annotation.CommandType;
-import org.apache.fineract.commands.handler.NewCommandSourceHandler;
-import org.apache.fineract.infrastructure.core.api.JsonCommand;
-import org.apache.fineract.infrastructure.core.data.CommandProcessingResult;
-import org.springframework.stereotype.Service;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.fineract.command.core.Command;
+import org.apache.fineract.command.core.CommandHandler;
+import org.apache.fineract.investor.data.ExternalAssetOwnerTransferResponse;
+import
org.apache.fineract.investor.data.request.ExternalAssetOwnerCancelRequest;
+import org.springframework.stereotype.Component;
+import org.springframework.transaction.annotation.Transactional;
+@Slf4j
+@Component
@RequiredArgsConstructor
-@Service
-@CommandType(entity = "LOAN", action = "CANCEL")
-public class CancelTransactionFromExternalAssetOwnerHandler implements
NewCommandSourceHandler {
+public class CancelTransactionFromExternalAssetOwnerHandler
Review Comment:
Inconsistent naming... please see other PRs that are already merged for
proper naming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
