somasorosdpc commented on code in PR #5847:
URL: https://github.com/apache/fineract/pull/5847#discussion_r3260880457
##########
fineract-charge/src/main/java/org/apache/fineract/portfolio/charge/service/ChargeDropdownReadPlatformServiceImpl.java:
##########
@@ -124,4 +124,36 @@ public List<EnumOptionData>
retrieveSharesCollectionTimeTypes() {
return
Arrays.asList(chargeTimeType(ChargeTimeType.SHAREACCOUNT_ACTIVATION),
chargeTimeType(ChargeTimeType.SHARE_PURCHASE),
chargeTimeType(ChargeTimeType.SHARE_REDEEM));
}
+
+ @Override
+ public List<EnumOptionData> retrieveCalculationTypes(ChargeAppliesTo
chargeAppliesTo, ChargeTimeType chargeTimeType) {
+ if (ChargeAppliesTo.WORKING_CAPITAL_LOAN.equals(chargeAppliesTo)) {
+ if (chargeTimeType == null) {
Review Comment:
I like the idea to fallback to empty list. I'm adding List.of() as fallback
value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
