vidakovic commented on code in PR #5856:
URL: https://github.com/apache/fineract/pull/5856#discussion_r3261810794


##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/collateralmanagement/data/CollateralProductUpdateRequest.java:
##########
@@ -16,24 +16,40 @@
  * specific language governing permissions and limitations
  * under the License.
  */
-package org.apache.fineract.template.data;
+package org.apache.fineract.portfolio.collateralmanagement.data;
 
+import io.swagger.v3.oas.annotations.Hidden;
 import java.io.Serial;
 import java.io.Serializable;
+import java.math.BigDecimal;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
 import lombok.Data;
 import lombok.NoArgsConstructor;
 
-@Builder
 @Data
+@Builder
 @NoArgsConstructor
 @AllArgsConstructor
-public class TemplateItemData implements Serializable {
+public class CollateralProductUpdateRequest implements Serializable {
 
     @Serial
     private static final long serialVersionUID = 1L;
 
-    private Integer id;
+    @Hidden
+    private Long collateralId;

Review Comment:
   No Jakarta Validation? Why is this one hidden? Please check the other 
request classes for validation annotations!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to