AshharAhmadKhan commented on PR #5858: URL: https://github.com/apache/fineract/pull/5858#issuecomment-4488882366
@oleksii-novikov-onix @adamsaghy The approach here is solid. A few thoughts on the open review comments: `@Transactional(propagation = REQUIRES_NEW)` on `removeOrphanedLocksForProcessedAccounts()` isn't needed. Spring Batch already wraps each tasklet in its own transaction and all prior steps have committed by the time this runs, so default `REQUIRED` is fine. `nullCobBusinessDate` in `LockRequest` is there so tests can place a lock with a null cob date through the API, which is needed to cover the `lock_placed_on_cob_business_date IS NOT NULL` filter in the delete query. Without it there's no way to test that edge case. Also agree on `log.info`, `log.debug` makes more sense since this runs on every COB execution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
