adamsaghy commented on PR #5813:
URL: https://github.com/apache/fineract/pull/5813#issuecomment-4506680600
@mansi75 Please rebase the PR with latest changes of `develop` branch.
Also please review the failing test cases:
```
Test
givenActiveLoanWithNullProduct_whenCalculateLoanCollectionData_thenNoExceptionAndOverAppliedIsNull()
FAILED
org.opentest4j.AssertionFailedError:
expected: 0
but was: 5000
at
app//org.apache.fineract.portfolio.delinquency.service.DelinquencyReadPlatformServiceImplTest.givenActiveLoanWithNullProduct_whenCalculateLoanCollectionData_thenNoExceptionAndOverAppliedIsNull(DelinquencyReadPlatformServiceImplTest.java:225)
```
and
```
Test
givenPendingLoanWithNullProduct_whenCalculateLoanCollectionData_thenNoExceptionAndOverAppliedIsNull()
FAILED
java.lang.NullPointerException: Cannot invoke
"org.apache.fineract.portfolio.loanproduct.domain.LoanProduct.isAllowApprovedDisbursedAmountsOverApplied()"
because the return value of
"org.apache.fineract.portfolio.loanaccount.domain.Loan.getLoanProduct()" is null
at
org.apache.fineract.portfolio.delinquency.service.DelinquencyReadPlatformServiceImplTest.givenPendingLoanWithNullProduct_whenCalculateLoanCollectionData_thenNoExceptionAndOverAppliedIsNull(DelinquencyReadPlatformServiceImplTest.java:191)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
