adamsaghy commented on PR #5713: URL: https://github.com/apache/fineract/pull/5713#issuecomment-4518736264
> @adamsaghy , I checked it out and it looks like `NotificationHelper` is already fully orphaned. `FeignNotificationHelper` was added upstream as the replacement, and `NotificationApiTest` has already been updated to use it. I could not find anything importing or calling `NotificationHelper` anymore. > > So I think the only remaining work is simply removing `NotificationHelper.java` rather than rewriting it. > > Happy to open a PR for the cleanup. Does that sound right to you? Thank you, go ahead! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
