elnafateh commented on code in PR #5888:
URL: https://github.com/apache/fineract/pull/5888#discussion_r3303705339
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/shares/ShareAccountHelper.java:
##########
@@ -146,4 +80,38 @@ public ShareAccountHelper withCharges(final
List<Map<String, Object>> charges) {
this.charges.addAll(charges);
return this;
}
+
+ public String build() {
Review Comment:
@adamsaghy After thorough investigation, The Share test suite cannot be
partially migrated:
1. No feign API exists for `ShareProductTransactionHelper` and
`ShareDividendsTransactionHelper`
2. `ShareAccountTransactionHelper` has no PUT feign method for
`updateShareAccount`
3. All callers pass raw JSON strings and read responses as `Map<String,
Object>` with
direct field access inside assertions — migrating the Helper alone breaks
the callers
The only clean path is migrating the entire Share suite in one dedicated PR.
I'll open that as a follow-up linked to FINERACT-2165. what do you make of
it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
