ruzeynalov commented on code in PR #5870: URL: https://github.com/apache/fineract/pull/5870#discussion_r3303892783
########## fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature: ########## @@ -2,7 +2,7 @@ Feature: Working Capital Loan Repayment Review Comment: @budaidev I agree that for rows with no applied payment the new fields are null, but the value of asserting them is on the rows where they're non-null. WorkingCapitalLoanRepayment.feature has 14 scenarios that apply actual repayments via "Customer makes repayment"; in those scenarios actualBalance and actualDiscountFeeBalance carry the new state this implementation added (netDisb − payment, discountFee − cumulativeActualAmort). Currently that state is unverified at the e2e level. The step def WorkingCapitalLoanAccountStepDef.extractWcScheduleCellValue is switch-based, so missing columns silently skip — all tests pass but doesn't actually exercise the new fields. Perhaps there could be following test created additionally - single dedicated scenario that walks one loan through multiple repayments and asserts the actual progression. I can add this test to this PR ########## fineract-e2e-tests-runner/src/test/resources/features/WorkingCapitalLoanRepayment.feature: ########## @@ -2,7 +2,7 @@ Feature: Working Capital Loan Repayment Review Comment: @budaidev I agree that for rows with no applied payment the new fields are null, but the value of asserting them is on the rows where they're non-null. WorkingCapitalLoanRepayment.feature has 14 scenarios that apply actual repayments via "Customer makes repayment"; in those scenarios actualBalance and actualDiscountFeeBalance carry the new state this implementation added (netDisb − payment, discountFee − cumulativeActualAmort). Currently that state is unverified at the e2e level. The step def WorkingCapitalLoanAccountStepDef.extractWcScheduleCellValue is switch-based, so missing columns silently skip — all tests pass but doesn't actually exercise the new fields. Perhaps there could be following test created additionally - single dedicated scenario that walks one loan through multiple repayments and asserts the actual progression. I can add this test to PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
