adamsaghy opened a new pull request, #5908:
URL: https://github.com/apache/fineract/pull/5908

   ## Description
   
   - Added Docker log artifacts and cleanup to build-docker.yml and 
smoke-messaging.yml.
   - Fixed build-docker.yml so check_worker_health is actually used for MariaDB 
worker health/info checks.
   - Hardened unsafe PR event interpolation in pr-title-check.yml and 
verify-api-backward-compatibility.yml.
   - Reviewed permissions: the workflows are now least-privilege for their 
behavior. Most only need contents: read; PR title check uses pull-requests: 
read; stale keeps write permissions because it closes/issues PRs.
   - Remove PR comment logic (it was not working due to safety concerns)
   - Remove `mifos-fineract-client-publush.yml` -> Moved to Mifos repository 
(where it belongs)
   
   ## Checklist
   
   Please make sure these boxes are checked before submitting your pull request 
- thanks!
   
   - [ ] Write the commit message as per [our 
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
   - [ ] Acknowledge that we will not review PRs that are not passing the build 
_("green")_ - it is your responsibility to get a proposed PR to pass the build, 
not primarily the project's maintainers.
   - [ ] Create/update [unit or integration 
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the 
changes made.
   - [ ] Follow our [coding 
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
   - [ ] Add required Swagger annotation and update API documentation at 
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with 
details of any API changes
   - [ ] [This PR must not be a "code 
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
 Large changes can be made in a branch, with assistance. Ask for help on the 
[developer mailing list](https://fineract.apache.org/#contribute).
   
   Your assigned reviewer(s) will follow our [guidelines for code 
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to