SamaSVM commented on PR #5899:
URL: https://github.com/apache/fineract/pull/5899#issuecomment-4592397585

   > Thanks for this patch and for starting the [dev list 
discussion](https://lists.apache.org/thread/3hdy1qc30xfzwb3ml6118o7p9mn6t22w), 
Vlad! Thank you Ádám and @Aman-Mittal for your feedback.
   > 
   > I generated a binary release tarball artifact with the `binaryDistTar` 
task and it looked good (no category X jars included).
   > 
   > [These 
instructions](https://fineract.apache.org/docs/current/#_run_from_binary) are 
now wrong. Will you update 
`fineract-doc/src/docs/en/chapters/release/process-step09.adoc`? Build a binary 
release artifact and Docker image locally, test those, and let me know how it 
goes.
   > 
   > Finally, will you try the `generateLicenseReport` task? I wonder if we 
want to manually 
[exclude](https://github.com/jaredsburrows/gradle-license-plugin#configuration) 
the jars we are no longer packaging, or if it can do that automatically. I see 
some are marked "Not Packaged" but I don't understand what that means.
   
   I've verified the "Build a binary release artifact and Docker image 
locally", and everything looks good — no Category X jars are included.
   
   I've also updated 
fineract-doc/src/docs/en/chapters/release/process-step09.adoc, please check.
   
   I have some difficulties running 'generateLicenseReport' locally, but I'll 
continue working it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to