Wiki05 commented on PR #5592: URL: https://github.com/apache/fineract/pull/5592#issuecomment-4600334664
@adamsaghy Yes, it is completely valid! I performed a deep dive into the Git history and the test execution tree to verify why. The underlying calculation flaw was actually resolved structurally by the fixes introduced in FINERACT-1981 (commit 89f7fd2), which corrected how LoanTrancheDisbursementCharge mappings are handled and flushed during the live disbursement block. Our new test case accurately mirrors the complete Jira workflow for FINERACT-2520: it sets up a strict progressive schedule (HORIZONTAL processing engine), injects a percentage-based charge, executes the full disbursement flow, and validates that Period 0's fee calculations are perfectly accounted for. Since the bug was fixed as a side-effect of FINERACT-1981, this PR serves as the dedicated regression test suite specifically explicitly tracking the acceptance criteria for FINERACT-2520, guaranteeing that future progressive loan refactors won't break disbursement fee calculations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
