Aman-Mittal commented on PR #5927: URL: https://github.com/apache/fineract/pull/5927#issuecomment-4621715822
> > > > @adamsaghy I think we can also allow upload logs in case of release ready branches. What do you think on that? While on PR we can only upload failure logs but release ready branches i think it would be great practice to keep logs on that. > > > > > > > > > I am not sure, i am following you on this one. > > > > My reasoning behind this is that. from what i know that will be used by many forks and organizations so it will be beneficial for us in that case if something gone wrong in code despite passing checks and e2e. > > > > Sometimes keeping this logs comes handy if there is any logical bugs or any undetected regressions later on. Or for rollback anything lateron. > > > > I am not blocking this PR but for observability we need to rethink that. > > I dont think we did or used the logs for that ever... > > Logical bugs: lead to bugfixes, but you wont be able to identify by going through the "green" tests... > Undetected regressions: same applies > Rollback: not sure how it matters... > > The rule of thumb we were following so far: `always go ahead`. > In short, if something got broken and easy to fix: we fixed with a follow-up bug ticket, if not straightforward, we reversed to latest green build. > Thanks for reply. Then it's nothing to worry about. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
