adamsaghy commented on code in PR #5940:
URL: https://github.com/apache/fineract/pull/5940#discussion_r3374346332
##########
fineract-loan/src/main/java/org/apache/fineract/portfolio/loanaccount/service/LoanChargeService.java:
##########
@@ -232,6 +232,11 @@ public void addLoanCharge(final Loan loan, final
LoanCharge loanCharge) {
update(loanCharge, chargeAmt, loanCharge.getDueLocalDate(), amount,
loan.fetchNumberOfInstallmentsAfterExceptions(),
totalChargeAmt);
+ // Skip zero-value charges
Review Comment:
Adding 0 charge is incorrect and it should be stopped at validation and or
during charge amount calculation. Silent return is misleading and hiding a
potential issue!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
