oleksii-novikov-onix commented on code in PR #5993:
URL: https://github.com/apache/fineract/pull/5993#discussion_r3426552738
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/PasswordPreferencesHelper.java:
##########
@@ -18,85 +18,29 @@
*/
package org.apache.fineract.integrationtests.common;
-import com.google.gson.Gson;
-import io.restassured.specification.RequestSpecification;
-import io.restassured.specification.ResponseSpecification;
-import java.util.HashMap;
+import static org.apache.fineract.client.feign.util.FeignCalls.ok;
-public final class PasswordPreferencesHelper {
-
- private PasswordPreferencesHelper() {
-
- }
-
- private static final String PASSWORD_PREFERENCES_URL =
"/fineract-provider/api/v1/passwordpreferences";
-
- // TODO: Rewrite to use fineract-client instead!
- // Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
- // org.apache.fineract.client.models.PostLoansLoanIdRequest)
- @Deprecated(forRemoval = true)
- public static Object updatePasswordPreferences(final RequestSpecification
requestSpec, final ResponseSpecification responseSpec,
- String validationPolicyId) {
- final String UPDATE_PASSWORD_PREFERENCES_URL =
PASSWORD_PREFERENCES_URL + "?" + Utils.TENANT_IDENTIFIER;
- // system.out.println("---------------------------------UPDATE PASSWORD
- // PREFERENCE---------------------------------------------");
- return Utils.performServerPut(requestSpec, responseSpec,
UPDATE_PASSWORD_PREFERENCES_URL,
- updatePreferencesAsJson(validationPolicyId), "");
- }
+import java.util.List;
+import
org.apache.fineract.client.models.GetPasswordPreferencesTemplateResponse;
+import org.apache.fineract.client.models.PutPasswordPreferencesTemplateRequest;
- // TODO: Rewrite to use fineract-client instead!
- // Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
- // org.apache.fineract.client.models.PostLoansLoanIdRequest)
- @Deprecated(forRemoval = true)
- public static Object updateWithInvalidValidationPolicyId(final
RequestSpecification requestSpec,
- final ResponseSpecification responseSpec, String
invalidValidationPolicyId, String jsonAttributeToGetback) {
- final String UPDATE_PASSWORD_PREFERENCES_URL =
PASSWORD_PREFERENCES_URL + "?" + Utils.TENANT_IDENTIFIER;
- // system.out
- // .println("---------------------------------UPDATE PASSWORD
- // PREFERENCES WITH INVALID
- // ID-----------------------------------------");
- return Utils.performServerPut(requestSpec, responseSpec,
UPDATE_PASSWORD_PREFERENCES_URL,
- updatePreferencesWithInvalidId(invalidValidationPolicyId),
jsonAttributeToGetback);
- }
+public final class PasswordPreferencesHelper {
- // TODO: Rewrite to use fineract-client instead!
- // Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
- // org.apache.fineract.client.models.PostLoansLoanIdRequest)
- @Deprecated(forRemoval = true)
- public static String updatePreferencesAsJson(String validationPolicyId) {
- final HashMap<String, Object> map = new HashMap<>();
- map.put("validationPolicyId", validationPolicyId);
- return new Gson().toJson(map);
- }
+ private PasswordPreferencesHelper() {}
- // TODO: Rewrite to use fineract-client instead!
- // Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
- // org.apache.fineract.client.models.PostLoansLoanIdRequest)
- @Deprecated(forRemoval = true)
- public static String updatePreferencesWithInvalidId(String
invalidValidationPolicyId) {
- final HashMap<String, Object> map = new HashMap<>();
- map.put("validationPolicyId", invalidValidationPolicyId);
- return new Gson().toJson(map);
+ public static void updatePasswordPreferences(String validationPolicyId) {
+ ok(() -> {
+
FineractFeignClientHelper.getFineractFeignClient().passwordPreferences()
+ .update7(new
PutPasswordPreferencesTemplateRequest().validationPolicyId(Long.parseLong(validationPolicyId)));
+ return null;
Review Comment:
Instead of returning null, you can use FeignCalls.executeVoid()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
