adamsaghy commented on code in PR #5940:
URL: https://github.com/apache/fineract/pull/5940#discussion_r3435577580
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientCharge.java:
##########
@@ -94,12 +94,9 @@ protected ClientCharge() {
//
}
- public static ClientCharge createNew(final Client client, final Charge
charge, final JsonCommand command) {
- BigDecimal amount =
command.bigDecimalValueOfParameterNamed(ClientApiConstants.amountParamName);
+ public static ClientCharge createNew(final Client client, final Charge
charge, final BigDecimal amount, final JsonCommand command) {
Review Comment:
See no changes...no reply...
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/service/ClientChargeWritePlatformServiceImpl.java:
##########
@@ -95,7 +99,12 @@ public CommandProcessingResult addCharge(Long clientId,
JsonCommand command) {
throw new ChargeCannotBeAppliedToException("client",
errorMessage, charge.getId());
}
- final ClientCharge clientCharge = ClientCharge.createNew(client,
charge, command);
+ BigDecimal roundedAmount = calculateRoundedChargeAmount(charge,
command);
Review Comment:
See no changes...no reply...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
