adamsaghy commented on code in PR #6000:
URL: https://github.com/apache/fineract/pull/6000#discussion_r3441243167


##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanNearBreachChangeReadServiceImpl.java:
##########
@@ -0,0 +1,54 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.fineract.portfolio.workingcapitalloan.service;
+
+import java.util.List;
+import lombok.RequiredArgsConstructor;
+import 
org.apache.fineract.portfolio.workingcapitalloan.data.WorkingCapitalLoanNearBreachChangeData;
+import 
org.apache.fineract.portfolio.workingcapitalloan.domain.WorkingCapitalLoanNearBreachChange;
+import 
org.apache.fineract.portfolio.workingcapitalloan.exception.WorkingCapitalLoanNotFoundException;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanNearBreachChangeRepository;
+import 
org.apache.fineract.portfolio.workingcapitalloan.repository.WorkingCapitalLoanRepository;
+import org.springframework.stereotype.Service;
+import org.springframework.transaction.annotation.Transactional;
+
+@Service
+@RequiredArgsConstructor
+@Transactional(readOnly = true)
+public class WorkingCapitalLoanNearBreachChangeReadServiceImpl implements 
WorkingCapitalLoanNearBreachChangeReadService {
+
+    private final WorkingCapitalLoanNearBreachChangeRepository repository;
+    private final WorkingCapitalLoanRepository loanRepository;
+
+    @Override
+    public List<WorkingCapitalLoanNearBreachChangeData> 
retrieveNearBreachChangeHistory(final Long loanId) {
+        if (!loanRepository.existsById(loanId)) {
+            throw new WorkingCapitalLoanNotFoundException(loanId);
+        }
+        return 
repository.findByWorkingCapitalLoanIdOrderByCreatedDateDesc(loanId).stream().map(e
 -> toData(e, loanId)).toList();
+    }
+
+    private WorkingCapitalLoanNearBreachChangeData toData(final 
WorkingCapitalLoanNearBreachChange entity, final Long loanId) {

Review Comment:
   Please use mapper for this. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to