[
https://issues.apache.org/jira/browse/FINERACT-2651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18090422#comment-18090422
]
Dhroov Sankla commented on FINERACT-2651:
-----------------------------------------
Hi team,
I would like to take up this task as my first contribution to Apache Fineract.
Upon analyzing the Mix report module, I noticed that `MixReportApiResource`
currently returns a raw `String` for the XML endpoint. I propose refactoring
this to return a explicitly typed `jakarta.ws.rs.core.Response` wrapper entity
to enforce JAX-RS type safety and native content negotiation, while clearing
out the old placeholder TODO comments in both the resource and builder classes.
Please let me know if this approach looks good to the maintainers so I can
submit a pull request for review. Thanks!
> Refactor MixReportApiResource to enforce type-safe JAX-RS Response patterns
> ---------------------------------------------------------------------------
>
> Key: FINERACT-2651
> URL: https://issues.apache.org/jira/browse/FINERACT-2651
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Reports
> Reporter: Dhroov Sankla
> Priority: Minor
>
> While exploring the Mix module, I noticed a couple of structural *TODO*
> comments regarding type safety and marshalling engines.
> Currently, `{*}MixReportApiResource.java{*}` returns a raw `String` for the
> XBRL report endpoint, which bypasses native JAX-RS framework response
> handling and content negotiation.
> Proposed Changes:
> 1. Refactor `retrieveXBRLReport` inside `MixReportApiResource` to return an
> explicitly typed `jakarta.ws.rs.core.Response` wrapper entity.
> 2. Remove the outdated placeholder TODO comments in `MixReportApiResource`
> and `MixReportXBRLBuilder` to clean up the codebase.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
