DeathGun44 commented on code in PR #6005:
URL: https://github.com/apache/fineract/pull/6005#discussion_r3448746544


##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/client/feign/FeignLoanTestBase.java:
##########
@@ -120,6 +153,23 @@ protected Long createLoanProduct(PostLoanProductsRequest 
request) {
         return loanHelper.createLoanProduct(request);
     }
 
+    protected GetLoanProductsProductIdResponse retrieveLoanProduct(Long 
productId) {
+        return loanHelper.retrieveLoanProduct(productId);
+    }
+
+    protected PutLoanProductsProductIdResponse updateLoanProduct(Long 
productId, PutLoanProductsProductIdRequest request) {
+        return loanHelper.updateLoanProduct(productId, request);
+    }
+
+    /**
+     * Updates a loan product using raw JSON. Use this overload when you need 
to send explicit null values in the
+     * request body, which the typed Feign client cannot express due to the 
global NON_NULL ObjectMapper configuration.
+     */
+    protected void updateLoanProduct(Long productId, String rawJsonBody) {

Review Comment:
   Done! It's now a private method in FixedLengthLoanProductIntegrationTest.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to