mariiaKraievska commented on PR #5992: URL: https://github.com/apache/fineract/pull/5992#issuecomment-4766345776
> Why is the breach action's `action` typed as `DelinquencyAction`? #5983 had a dedicated `WorkingCapitalLoanBreachActionType`, and reusing the delinquency domain's enum here couples breach to delinquency and reads oddly (a breach action whose type is a 'delinquency action'). Wouldn't it make more sense to keep a breach-specific type, or extract a shared action enum that isn't named after one of the two domains? wdyt? @galovics thank you, fully agree. I initially reused DelinquencyAction to mirror the delinquency reschedule implementation while developing breach actions, but you're right that breach should have its own type. I've aligned this with #5983. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
