nidhiii128 opened a new pull request, #6015:
URL: https://github.com/apache/fineract/pull/6015
## Description
Migrates the "update group" (PUT `/v1/groups/{groupId}`) and "delete group"
(DELETE `/v1/groups/{groupId}`) REST endpoints from the legacy JSON-blob
command-processing path to the new typed fineract-command framework.
## Scope (PR 2 of 3 for FINERACT-2291)
- New typed `GroupUpdateRequest` / `GroupUpdateResponse` POJOs with Jakarta
Validation
- New typed `GroupDeleteRequest` / `GroupDeleteResponse` POJOs
- New `GroupUpdateCommand`, `GroupDeleteCommand` and their corresponding
handlers using `CommandHandler<REQ, RES>`
- `GroupingTypesWritePlatformService` gets new typed
`updateGroup(GroupUpdateRequest)` and `deleteGroup(GroupDeleteRequest)`
overloads. Legacy methods kept since they're still used by
`DeleteCenterCommandHandler` and other code paths.
- Controller methods now route through `CommandDispatcher`
- AntMatchers added in `SecurityConfig` for `PUT /api/*/groups/*`
(UPDATE_GROUP) and `DELETE /api/*/groups/*` (DELETE_GROUP)
- Resilience4j configuration added for `commandGroupUpdate` and
`commandGroupDelete`
- 7 translation keys added to `ValidationMessages.properties`
- Legacy `UpdateGroupCommandHandler` and `DeleteGroupCommandHandler` deleted
- Removed trivial `@ApiResponse(200)` and `@RequestBody` swagger annotations
on the migrated endpoints (return types are self-describing)
## Expected CI failure
`run-api-backward-compatibility` will fail due to removal of trivial
`@ApiResponse(200)` annotations — same as PR #5952 (per @vidakovic's guidance).
## Checklist
Please make sure these boxes are checked before submitting your pull request
- thanks!
- [ ] Write the commit message as per [our
guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests)
- [ ] Acknowledge that we will not review PRs that are not passing the build
_("green")_ - it is your responsibility to get a proposed PR to pass the build,
not primarily the project's maintainers.
- [ ] Create/update [unit or integration
tests](https://fineract.apache.org/docs/current/#_testing) for verifying the
changes made.
- [ ] Follow our [coding
conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions).
- [ ] Add required Swagger annotation and update API documentation at
fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with
details of any API changes
- [ ] [This PR must not be a "code
dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit).
Large changes can be made in a branch, with assistance. Ask for help on the
[developer mailing list](https://fineract.apache.org/#contribute).
Your assigned reviewer(s) will follow our [guidelines for code
reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
