adamsaghy commented on code in PR #5937:
URL: https://github.com/apache/fineract/pull/5937#discussion_r3467327608
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanWritePlatformServiceImpl.java:
##########
@@ -969,6 +985,72 @@ public CommandProcessingResult
updatePeriodPaymentRate(final Long loanId, final
.withLoanId(loanId).with(changes).build();
}
+ public CommandProcessingResult undoTransaction(final WorkingCapitalLoan
loan, final WorkingCapitalLoanTransaction transaction,
+ JsonCommand command) {
+
+ validator.validateUndoTransaction(command, loan, transaction);
+
+ Map<String, Object> changes = new HashMap<>();
+ changes.put("reversed", true);
+ transaction.setReversed(true);
+
+ ExternalId reversalExternalId = externalIdFactory
+
.create(command.stringValueOfParameterNamedAllowingNull(WorkingCapitalLoanConstants.reversalExternalIdParamName));
+ transaction.setReversalExternalId(reversalExternalId);
+ changes.put("reversalExternalId", reversalExternalId);
+
+ LocalDate reversedOnDate = ThreadLocalContextUtil.getBusinessDate();
+ transaction.setReversedOnDate(reversedOnDate);
+ changes.put("reversedOnDate", reversedOnDate);
+
+ if (loan.getLoanProduct().getAccountingRule().isCashBased()) {
Review Comment:
Minor: usually this is the last operation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
