adamsaghy commented on code in PR #6084:
URL: https://github.com/apache/fineract/pull/6084#discussion_r3520717661
##########
fineract-provider/src/test/java/org/apache/fineract/batch/command/CommandStrategyUtilsTest.java:
##########
@@ -127,8 +127,8 @@ public void
testBuildRequestFromQueryParametersTypeConversion(String fieldName,
// then
assertThat(result).isNotNull();
Object actualValue = getFieldValue(result, fieldName);
- if (expectedValue instanceof BigDecimal) {
- assertThat((BigDecimal)
actualValue).isEqualByComparingTo((BigDecimal) expectedValue);
+ if (expectedValue instanceof BigDecimal bigDecimal) {
Review Comment:
Would you mind to use a different field name? `bigDecimal` is the type, not
the purpose.
`expectedValueAsBigDecimal`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
