vidakovic commented on code in PR #6085:
URL: https://github.com/apache/fineract/pull/6085#discussion_r3537959140
##########
integration-tests/src/test/java/org/apache/fineract/integrationtests/common/ClientHelper.java:
##########
@@ -265,14 +264,14 @@ public static PostClientsResponse createClient(final
RequestSpecification reques
// Example:
org.apache.fineract.integrationtests.common.loans.LoanTransactionHelper.disburseLoan(java.lang.Long,
// org.apache.fineract.client.models.PostLoansLoanIdRequest)
@Deprecated(forRemoval = true)
- public static PostClientClientIdAddressesResponse
createClientAddress(final RequestSpecification requestSpec,
+ public static HashMap<String, Object> createClientAddress(final
RequestSpecification requestSpec,
Review Comment:
Why do we suddenly lose the type information here? This looks like a
regression and indicates that OpenAPI doesn't have enough information available
to determine the proper Java type... which then falls back on HashMap. We
should fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
