aya-abdallah-FOO opened a new pull request, #6120: URL: https://github.com/apache/fineract/pull/6120
## Description
Fixes two issues with the `GET /v1/makercheckers` endpoint:
### 1. Date filters non-functional
The `makerDateTimeFrom` / `makerDateTimeTo` filters compared against
`made_on_date`, but records created after the UTC-offset migration are stored
in `made_on_date_utc`. This
made date-range filtering silently return no results for those records.
Fix applies the same OR-pattern already used by `AuditsApiResource`: check
both `made_on_date` and `made_on_date_utc` so filtering works correctly
regardless of which column a
record uses.
Also adds a fallback date parser in `MakerCheckerRequest` for the `"dd
MMMM yyyy"` format (e.g. `02 June 2026`), which the existing
`DateUtils.convertDateTimeStringToOffsetDateTime` does not support when
`dateFormat`/`locale` params are absent, causing a 500.
### 2. Username filter missing
The `mk` (appuser) table is already joined in the underlying query. This
adds a `?username=` query parameter that filters entries by the maker's
username via a `LIKE` prefix
match against `mk.username`.
## Changes
- `MakercheckersApiResource.java` — date filter uses OR-pattern on both
columns; username LIKE filter added
- `MakerCheckerRequest.java` — `username` query param added;
`getMakerDateTimeFrom/To()` gains `dd MMMM yyyy` fallback parsing
## Testing
- Compiled clean against `develop` with JDK 21
- All 20 unit tests in `org.apache.fineract.commands.*` pass
## Related
- Apache JIRA: https://issues.apache.org/jira/browse/FINERACT-2683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
