budaidev opened a new pull request, #6125: URL: https://github.com/apache/fineract/pull/6125
Allow charge-adjustment transactions on closed (obligations met) and overpaid working capital loans: the adjustment is booked as overpayment and the loan moves to (or stays) OVERPAID. The ACTIVE-loan path is unchanged. - adjustmentForLoanCharge branches on loan status. For CLOSED_OBLIGATIONS_MET and OVERPAID the full adjustment amount is booked as overpayment via the new WorkingCapitalLoanBalanceUpdater.applyOverpayment (keeping the balance updater the single owner of the overpayment bucket) and the LOAN_OVERPAID transition is driven; feePaid/penaltyPaid stay unchanged. A guard rejects the path when the charge is not fully settled. - Feign integration test covering closed->overpaid (full and partial) and overpaid->overpaid. Accounting and undo reversal are out of scope (handled in separate stories). Claude-Session: https://claude.ai/code/session_01W71wEg68edP92tpJCZ8Ry7 ## Description Describe the changes made and why they were made. (Ignore if these details are present on the associated Apache Fineract JIRA ticket.) ## Checklist Please make sure these boxes are checked before submitting your pull request - thanks! - [ ] Write the commit message as per [our guidelines](https://github.com/apache/fineract/blob/develop/CONTRIBUTING.md#pull-requests) - [ ] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers. - [ ] Create/update [unit or integration tests](https://fineract.apache.org/docs/current/#_testing) for verifying the changes made. - [ ] Follow our [coding conventions](https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions). - [ ] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes - [ ] [This PR must not be a "code dump"](https://cwiki.apache.org/confluence/display/FINERACT/Pull+Request+Size+Limit). Large changes can be made in a branch, with assistance. Ask for help on the [developer mailing list](https://fineract.apache.org/#contribute). Your assigned reviewer(s) will follow our [guidelines for code reviews](https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
