DeathGun44 commented on code in PR #6084:
URL: https://github.com/apache/fineract/pull/6084#discussion_r3595966840
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/loanaccount/api/LoanTransactionsApiResource.java:
##########
@@ -162,7 +162,7 @@ public String
retrieveTransactionTemplate(@PathParam("loanId") @Parameter(descri
+ "\n" + "loans/1/transactions/template?command=charge-off" + "\n"
+ "loans/1/transactions/template?command=downPayment" + "\n"
+ "loans/1/transactions/template?command=interest-refund")
@ApiResponses({
- @ApiResponse(responseCode = "200", description = "OK", content =
@Content(schema = @Schema(implementation =
LoanTransactionsApiResourceSwagger.GetLoansLoanIdTransactionsTemplateResponse.class)))
})
Review Comment:
Understood! ,I've reverted the @ApiResponse change on
retrieveTransactionTemplate back to how it was
(GetLoansLoanIdTransactionsTemplateResponse).
Instead, following your suggestion, I just added the missing fields (reAge
and reAmortize options) directly into the LoanTransactionsApiResourceSwagger
definition so the Feign client can pick them up properly. No production
controller annotations or logic are modified anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
