rymghosn opened a new pull request, #6203:
URL: https://github.com/apache/fineract/pull/6203
The teller cashier "allocate cash" endpoint (POST
/tellers/{tellerId}/cashiers/{cashierId}/allocate) returned an unclear/generic
error when
txnAmount was not a valid number, instead of a proper validation message.
Changes made:
- CashierTransactionRequest.txnAmount (and its corresponding Swagger
schema in TellerApiResourceSwagger) is changed from BigDecimal to String, so
a malformed value reaches the deserializer instead of failing earlier at
JSON-binding time.
- TellerCommandFromApiJsonDeserializer now catches the parse failure when
extracting txnAmount and raises a PlatformApiDataValidationException
with a clear "Amount must be a number" message, reusing the existing
validation.msg.invalid.decimal.format error code.
This PR( https://issues.apache.org/jira/browse/FINERACT-2724 )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
