prajakta128 opened a new pull request, #6204:
URL: https://github.com/apache/fineract/pull/6204
## What
Removes an unreachable/no-op code block inside `doTransactionForCashier()`
in `TellerWritePlatformServiceJpaImpl.java`.
## Why
The block read an `entityType` parameter from the request and branched on
its value ("loan account", "savings account", "client"), but every branch was
either empty or entirely commented-out code. `entityType` was never referenced
again anywhere else in the method or the file, so the block had zero effect on
runtime behavior. The original author had already flagged it themselves:
// TODO: can we please remove this whole block?!? this is 20 lines of
dead code!!!
This PR simply deletes that block. No behavior change.
## Why no JIRA ticket
Per CONTRIBUTING.md, a JIRA ticket isn't required for changes that are
"truly trivial." This is a straightforward dead-code removal with no
functional impact, so I've opened this PR directly.
## Checklist
- [x] No behavior change — verified `entityType` is unused elsewhere in the
file
- [ ] Existing tests pass locally (pending — fixing local JAVA_HOME setup;
will confirm once CI runs / once resolved locally)
- [x] Not a "code dump" — single, focused change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
