KRYSTALM7 commented on PR #54:
URL:
https://github.com/apache/fineract-loan-origination/pull/54#issuecomment-5156328920
Hi @Aman-Mittal,
Wanted to flag a few things and get your feedback before this is reviewed:
1. **CSRF alert** — CodeQL is flagging CSRF protection on the customer chain
(line 59). I've updated it to use `ignoringRequestMatchers` instead of
`disable()` — both chains are stateless (JWT and Basic Auth) so CSRF is
not applicable here. Let me know if you'd prefer a different approach or
a suppression annotation.
2. **Still in progress** — Staff dashboard UI, document upload, and comments
are being built in parallel. This PR focuses on the auth and config
foundation those features will build on.
Happy to make any changes based on your feedback. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
