Aman-Mittal commented on issue #111:
URL: 
https://github.com/apache/fineract-backoffice-ui/issues/111#issuecomment-5158340773

   This is implemented on `main`. Closing.
   
   `filterNavItems` recurses into `item.children`, so filtering applies at 
every level rather than
   only to top-level entries — and a group whose children are all filtered out 
is itself removed
   rather than left as an empty heading:
   
   ```ts
   if (item.children) {
     const filteredChildren = filterNavItems(item.children, isVisible);
     if (filteredChildren.length === 0) return visible;   // drop the now-empty 
group
     visible.push({ ...item, children: filteredChildren });
   }
   ```
   
   Dividers are preserved. Covered by the group-level assertions in 
`e2e/rbac-feature-flag.spec.ts`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to