adamsaghy commented on code in PR #6174:
URL: https://github.com/apache/fineract/pull/6174#discussion_r3703538349
##########
fineract-savings/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsSchedularInterestPoster.java:
##########
@@ -150,6 +150,16 @@ private void batchUpdateJournalEntries(final
List<SavingsAccountData> savingsAcc
savingsAccountData.getId(),
auditDatetime, auditDatetime, false, BigDecimal.ZERO, BigDecimal.ZERO,
null,
savingsAccountTransactionData.getTransactionDate(), null, userId, userId,
DateUtils.getBusinessLocalDate() });
+ } else if
(savingsAccountData.getGlAccountIdForSavingsControl() != 0
Review Comment:
I am not sure about this.
In my understanding we should skip only if the resolved id is 0, no? Are you
sure this are the correct conditions?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
