vidakovic commented on code in PR #6231:
URL: https://github.com/apache/fineract/pull/6231#discussion_r3733959898
##########
fineract-command-audit/src/test/resources/application-test.properties:
##########
@@ -21,6 +21,6 @@ debug=true
fineract.command.enabled=true
fineract.command.audit.enabled=true
-fineract.command.hooks.audit-pre=${FINERACT_COMMAND_PROCESSORS_AUDIT_PRE:true}
-fineract.command.hooks.audit-post=${FINERACT_COMMAND_PROCESSORS_AUDIT_POST:true}
-fineract.command.hooks.audit-error=${FINERACT_COMMAND_PROCESSORS_AUDIT_ERROR:true}
+fineract.command.audit.hook-pre=${FINERACT_COMMAND_PROCESSORS_AUDIT_PRE:true}
+fineract.command.audit.hook-post=${FINERACT_COMMAND_PROCESSORS_AUDIT_POST:true}
Review Comment:
It is. This way it is more consistent and doesn't require anything defined
outside of this module's scope (i.e. the properties map at
`fineract.command.hooks`). Might look like a minor thing, but this is also a
kind of inter-dependency - even if only on a configuration level and implicit.
For this new stuff I'd like to keep things as independent as possible.
##########
fineract-provider/src/test/resources/application-test.properties:
##########
@@ -361,9 +361,9 @@ fineract.command.jdbc.enabled=true
fineract.command.jdbc.file-dead-letter-queue-enabled=false
fineract.command.jdbc.file-dead-letter-queue-path=./build/fineract/dlq
fineract.command.audit.enabled=true
-fineract.command.hooks.audit-pre=true
-fineract.command.hooks.audit-post=true
-fineract.command.hooks.audit-error=true
+fineract.command.audit.hook-pre=true
+fineract.command.audit.hook-post=true
Review Comment:
See previous comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
