adamsaghy commented on code in PR #6235: URL: https://github.com/apache/fineract/pull/6235#discussion_r3734757042
########## fineract-provider/src/main/resources/db/changelog/tenant/parts/0245_delete_trailing_space_standinginstruction_permissions.xml: ########## @@ -0,0 +1,75 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<!-- + Liquibase changeSet to safely delete duplicate m_permission rows + for Standing Instruction permissions WITHOUT trailing spaces, + keeping the legacy trailing-space versions. + + Deletes ONLY: + - 'CREATE_STANDINGINSTRUCTION' + - 'UPDATE_STANDINGINSTRUCTION' + - 'DELETE_STANDINGINSTRUCTION' + + Safety rules: + - Delete ONLY if a trailing-space version already exists. + - Do NOT modify or insert any permissions. + - Do NOT touch m_role_permission. + - Idempotent and safe to re-run. + - PostgreSQL only. +--> +<databaseChangeLog xmlns="http://www.liquibase.org/xml/ns/dbchangelog"; + xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://www.liquibase.org/xml/ns/dbchangelog http://www.liquibase.org/xml/ns/dbchangelog/dbchangelog-4.1.xsd";> + + <changeSet id="0245_delete_non_spaced_standinginstruction_permissions" Review Comment: Why to delete the non-spaced over the trailing space one? Having trailing space in the permissions are clearly incorrect. Should we consider removing the one with extra space instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
