Aman-Mittal commented on issue #268:
URL:
https://github.com/apache/fineract-backoffice-ui/issues/268#issuecomment-5227043228
Correcting two things I got wrong when filing this, both found by comparing
against a mature implementation of the same platform before writing any code.
**Disburse to savings does not need a savings-account picker.** I wrote that
it does. It doesn't — the destination is the savings account linked to the loan
when the application was made, not something chosen at disbursement. The
platform refuses the command outright on a loan without one:
```
403 Disburse Loan with id:4 requires linked savings account for payment
```
So the dialog collects only the disbursement date, the amount and an
optional note. A picker would have implied a choice that does not exist.
**The unassign permission is `REMOVELOANOFFICER_LOAN`**, not the
`UNASSIGNLOANOFFICER_LOAN` the command name suggests. The platform publishes
only `UPDATELOANOFFICER_LOAN` and `REMOVELOANOFFICER_LOAN`; the name I assumed
is absent. Gating on a permission code that does not exist would have hidden
the action from everyone.
Also worth recording, since it changes nothing but could confuse a reader:
the command is spelled `disbursetosavings` in the wider ecosystem and
`disburseToSavings` in my original probe. Both work — the platform matches
command names case-insensitively, verified against a live instance. The
lowercase form is used for consistency.
One further note: the unassign-officer action does not exist in the
reference implementation either, so this gap is not unique to this app and
there was no prior art to follow for it.
Verified round trip before the code was written, then again through the
screen: assign → 200, `unassignloanofficer` with `{unassignedDate, locale,
dateFormat}` → 200 and `loanOfficerId` cleared. On the real loan view the menu
shows Unassign while an officer is assigned, and correctly hides Undo Last
Disbursal on a single-disbursal loan and Disburse to Savings on a loan that is
Active rather than Approved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
