Aman-Mittal commented on PR #207: URL: https://github.com/apache/fineract-backoffice-ui/pull/207#issuecomment-5227106906
This is a major version bump, and the version bump alone will not be enough — #167 already tracks exactly this work, including the code migration it needs. `src/app/app.config.ts:118` still wires translation up as: ```ts importProvidersFrom(TranslateModule.forRoot()), ``` which v18 replaces with `provideTranslateService`. `TranslateModule` is imported across **403 files**, so this is a repo-wide change rather than a dependency line. There is also a sibling package: #167 is written against `@ngx-translate/http-loader`, and the two have to move together. Suggest closing this in favour of #167, or reusing this branch to carry the migration so the bump and the code change land as one commit — merging the bump on its own would break the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
