vianmangal opened a new pull request, #319: URL: https://github.com/apache/fineract-backoffice-ui/pull/319
## What and why Replace the five manual Fineract array-date conversions in the `clients` feature with the existing `formatArrayDate` helper. This removes repeated month-offset arithmetic while preserving the guards around optional dates and the ISO strings expected by Ionic date controls. This covers the `clients` feature-directory portion of #257. ## Verification - `npm test -- --watch=false --include='src/app/features/clients/client-form.component.spec.ts' --include='src/app/features/clients/client-action-dialog.component.spec.ts'` (14 tests) - `npm test -- --watch=false` (894 tests) - `npm run lint` - `npm run format:check` - `npm run build` - `npm run check:icons` - `npm run i18n:check` - `./scripts/check-license.sh` - UI exercised through mocked component tests; no real Fineract backend was required for this refactor. ## Screenshots Not applicable; this is a behavior-preserving date-formatting refactor. ## Checklist - [x] I did not hand-edit generated files under `src/app/api/`. - [x] New component or service code uses the adapter boundary in `src/app/core/adapters/` instead of direct browser globals or imperative third-party APIs. (No new component or service code.) - [x] User-facing strings use translation keys. (No user-facing strings changed.) - [x] I added or updated tests appropriate to this change. - [x] UI workflow changes include suitable e2e coverage, including real-backend testing where relevant. (No UI workflow changed; component regression tests cover the date values.) - [x] Commits are signed — see [Commit Signing](CONTRIBUTING.md#commit-signing) in CONTRIBUTING.md. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
