vidakovic commented on code in PR #6110:
URL: https://github.com/apache/fineract/pull/6110#discussion_r3747080500
##########
fineract-provider/src/main/java/org/apache/fineract/portfolio/client/domain/ClientChargeRepositoryWrapper.java:
##########
@@ -28,18 +29,22 @@ public class ClientChargeRepositoryWrapper {
private final ClientChargeRepository repository;
private final OrganisationCurrencyRepositoryWrapper
organisationCurrencyRepository;
+ private final ClientChargeReadService clientChargeReadService;
Review Comment:
This is reversing the layered architecture... usually repositories should be
contained in services, but now we have a service contained in a repository that
in turn is probably contained in another service...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
