[
https://issues.apache.org/jira/browse/FINERACT-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18103319#comment-18103319
]
Adam Saghy commented on FINERACT-2747:
--------------------------------------
[~shubhamchaudhary29] Sounds okay to me. Make sure you are testing thoroughly
through many use cases, including edge cases as well.
> Add unit tests for FrequencyTypeUtil
> ------------------------------------
>
> Key: FINERACT-2747
> URL: https://issues.apache.org/jira/browse/FINERACT-2747
> Project: Apache Fineract
> Issue Type: Improvement
> Components: Test
> Reporter: Shubham Chaudhary
> Priority: Minor
>
> FrequencyTypeUtil provides comparison logic for frequencies expressed in
> DAYS, WEEKS, MONTHS, and YEARS, but currently has no dedicated unit tests.
> Adding unit tests would document the existing expected behaviour and protect
> the frequency conversion and comparison logic against regressions.
> Proposed coverage:
> 1. Compare frequencies having the same frequency type.
> 2. Compare equivalent frequencies using different frequency types.
> 3. Verify comparison when the first frequency is smaller.
> 4. Verify comparison when the first frequency is larger.
> 5. Cover DAYS, WEEKS, MONTHS, and YEARS.
> 6. Verify the current behaviour for unsupported frequency types.
> This ticket proposes test coverage only and does not change production
> behaviour.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
