adamsaghy commented on code in PR #6239:
URL: https://github.com/apache/fineract/pull/6239#discussion_r3748269179
##########
fineract-working-capital-loan/src/main/java/org/apache/fineract/portfolio/workingcapitalloan/service/WorkingCapitalLoanBreachScheduleServiceImpl.java:
##########
@@ -159,7 +159,9 @@ public void applyRepayment(final Long loanId, final
LocalDate transactionDate, f
return;
}
applyRepayment(currentPeriod.get(), amount, loanId);
- recalculatePastDueAmount(loanId);
+ if
(!currentPeriod.get().getToDate().isAfter(DateUtils.getBusinessLocalDate())) {
Review Comment:
This looks incorrect:
Should it be rather
`currentPeriod.get().getToDate().isBefore(DateUtils.getBusinessLocalDate))`?
If we are on the due date and that's the current business date matches with
that, we dont need to recalculate the past due amount.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
