airajena opened a new issue, #64: URL: https://github.com/apache/fineract-business-intelligence/issues/64
## Problem Code quality audit found that this repo's declared quality gates don't match what CI actually enforces: | Language | Linter declared | Enforced in CI | Result | |---|---|---|---| | Python | None | Job named **"Compile & Lint"** only runs `py_compile` | 42 issues found when actually linted | | SQL/dbt | None (no sqlfluff) | `dbt parse` only (syntax, not style) | Consistent by convention, unverified | | Shell | None (no shellcheck) | — | 3+ scripts with inconsistent/unsafe `set` flags | `py_compile` only confirms a Python file parses — it is not a linter and catches none of the issues a real linter would (unused variables, unsafe test patterns, outdated syntax, etc.). A CI job named "Compile & Lint" that does no linting is misleading — it looks like a quality gate but isn't one. ## Impact This isn't just a naming issue. Investigating what a real linter would find surfaced two genuine, previously-invisible bugs: - An unused-variable check would have caught a dataset mix-up in the Superset dashboard bootstrap script where 10 charts on the Repayment Behavior dashboard were silently querying the wrong dataset (aggregating across all history instead of showing the latest snapshot). - A shell script (`verify_extraction.sh`) was silently exiting on its first failed health check instead of running all checks and reporting a summary, because it inherited `set -e` from a sourced helper script without being written to tolerate it. ## Ask - Add `ruff` for Python, wire it into the existing "Compile & Lint" CI job so the name is accurate - Add `shellcheck` for shell scripts, standardize `set -euo pipefail` usage across scripts - Add `sqlfluff` for dbt SQL models - Fix whatever real issues these tools surface (not just cosmetic ones) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
